rsync 3.2.0 -> 3.2.2
And now some of my backups fail because rsync runs out of memory.
I don't get it. I've bisected the problem to a single commit*, but no matter how long I look at it, I don't see why that causes the maximum RSS from grow from 11M to 248M. Valgrind isn't helping, it doesn't seem to be a leak.
is this a zero-size allocation? https://github.com/WayneD/rsync/commit/11eb67eec9b4d990ae4df680cf7db77dad1b8630#diff-6ef31e939ebd526ea12b40e0c1b11233R701
@wolf480pl The logic in the two commits look the same to me, neither will allocate if count==0.
@ayo ok I can't read, didn't notice "count ?" at the beginning, sorry
@ayo you can start bisecting the hunks of the patch - add .patch to that URL, download that, revert the commit locally, edit the .patch file, and use 'git am' to apply the modified .patch
@ayo Excellent analysis & bug report.
@dredmorbius That doesn't explain why a new minor version suddenly uses 20+ times more memory. Doesn't seem to be an intentional change either, from what I can see.
@ayo Ok. I'd been aware of that bug.
Same version of rsync on both sides?
A lonely little town in the wider world of the fediverse.